Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added sync onboarding 31 days plus users button #547

Merged
merged 3 commits into from
Oct 8, 2023

Conversation

AnjaliDeshwani
Copy link
Contributor

@AnjaliDeshwani AnjaliDeshwani commented Oct 6, 2023

Issue - #539

Changes - A button is added to the dashboard site for SUPERUSER to run the API and sync the "group-onboarding-31d+" users.

Demo -
image

DashboardBtnDemo.mp4

Test Coverage :

image

Copy link
Member

@iamitprakash iamitprakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

button looks odd than others

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 6, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9e55359
Status: ✅  Deploy successful!
Preview URL: https://78bf2de0.dashboard-rds.pages.dev
Branch Preview URL: https://feature-synconboarding31d-us.dashboard-rds.pages.dev

View logs

@iamitprakash iamitprakash self-requested a review October 6, 2023 17:43
Copy link
Member

@iamitprakash iamitprakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-10-06 at 23 13 23 Please change time format as others. SS is from Prod

@AnjaliDeshwani
Copy link
Contributor Author

Screenshot 2023-10-06 at 23 13 23 Please change time format as others. SS is from Prod

I checked in code all of these buttons are using the same below function to get the time. I think "Date().toLocaleString()" shows the time depending on the browser and the user's locale settings

function getCurrentTimestamp() { return new Date().toLocaleString(); }

Copy link
Contributor

@anishpawaskar anishpawaskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🚀

@iamitprakash iamitprakash merged commit a1fb689 into develop Oct 8, 2023
5 checks passed
@iamitprakash iamitprakash deleted the feature/syncOnboarding31d+Users branch October 8, 2023 05:55
@AnjaliDeshwani AnjaliDeshwani mentioned this pull request Oct 8, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants