Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace /members with /users #548

Merged
merged 15 commits into from
Oct 12, 2023
Merged

replace /members with /users #548

merged 15 commits into from
Oct 12, 2023

Conversation

kotesh-arya
Copy link
Contributor

@kotesh-arya kotesh-arya commented Oct 6, 2023

Design Doc:

https://docs.google.com/document/d/1xvllP-qyZBAHFzp5Oh-7d-bTh_JHX7Ps_KsOTUSkPYE/edit?usp=sharing

Changes done:

The /members route is being used in 3 different pages to use all the Users Data and it is replaces with /users route with a similar response:

  1. Task creation page
    image
  2. Online-members page
    image

Test Coverage Stats:

image

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 6, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c706330
Status: ✅  Deploy successful!
Preview URL: https://f672505f.dashboard-rds.pages.dev
Branch Preview URL: https://replace-members-route.dashboard-rds.pages.dev

View logs

task/script.js Outdated Show resolved Hide resolved
Copy link
Member

@Achintya-Chatterjee Achintya-Chatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are failing , kindly look into it

@kotesh-arya
Copy link
Contributor Author

tests are failing , kindly look into it

Fixed them, thanks for pointing out 👍🏻

@iamitprakash iamitprakash merged commit cb2f0b3 into develop Oct 12, 2023
5 checks passed
@iamitprakash iamitprakash deleted the replace-members-route branch October 12, 2023 19:22
@kotesh-arya kotesh-arya mentioned this pull request Oct 13, 2023
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants