-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/user data pagination #891
base: develop
Are you sure you want to change the base?
Feature/user data pagination #891
Conversation
… we scroll, changed data fetching structure to fetch last user id
…ot visible in screen
… we scroll, changed data fetching structure to fetch last user id
…ot visible in screen
…anVeer/website-dashboard into feature/user-data-pagination
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put your feature behind feature flag also remove the mock data and comments
and what about the paginate API?
// createElement('span', {}, [ | ||
// user.first_name + ' ' + user.last_name + user.username, | ||
// ]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we get rid of this if not needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same, this is being currently used with the actual data I have just replicated my version to test out the mock data.
Hey who is working on backend for this? |
@IshanVeer Is your functionality behind a feature flag? |
Tests are missing? |
export const mockUsersData = { | ||
in_discord: [ | ||
{ | ||
id: 'user_1', | ||
discordId: '123456789', | ||
username: 'Alice', | ||
avatar: 'https://placekitten.com/50/50?image=1', | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey so for development, using mock data was suggested.
But not to push mock data code, in the PR
Make API calls according to the contract decided
and put it behind a feature flag
Date: 15/10/2024
Developer Name: Ishan Veer
Issue Ticket Number
Description
Previously all the data was being fetched at once which can cause performance issues. So things I worked on:
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
Test Coverage
Screenshot 1
Additional Notes
Currently testing it with mock data because API is still not paginated.