Feature/user data pagination #891
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
September 25, 2024 10:14
… we scroll, changed data fetching structure to fetch last user id
…ot visible in screen
… we scroll, changed data fetching structure to fetch last user id
…ot visible in screen
…anVeer/website-dashboard into feature/user-data-pagination
|
10 tasks
vinit717
requested changes
Oct 15, 2024
We had this conversation previously: |
sumitd94
reviewed
Oct 16, 2024
sumitd94
reviewed
Oct 16, 2024
Comment on lines
57
to
59
| // createElement('span', {}, [ | ||
| // user.first_name + ' ' + user.last_name + user.username, | ||
| // ]), |
There was a problem hiding this comment.
can we get rid of this if not needed?
There was a problem hiding this comment.
Same, this is being currently used with the actual data I have just replicated my version to test out the mock data.
sumitd94
reviewed
Oct 16, 2024
sumitd94
reviewed
Oct 16, 2024
sumitd94
reviewed
Oct 16, 2024
sumitd94
approved these changes
Oct 23, 2024
|
Hey who is working on backend for this? |
|
@IshanVeer Is your functionality behind a feature flag? |
|
Tests are missing? |
Comment on lines
+23
to
+30
| export const mockUsersData = { | ||
| in_discord: [ | ||
| { | ||
| id: 'user_1', | ||
| discordId: '123456789', | ||
| username: 'Alice', | ||
| avatar: 'https://placekitten.com/50/50?image=1', | ||
| }, |
There was a problem hiding this comment.
Hey so for development, using mock data was suggested.
But not to push mock data code, in the PR
Make API calls according to the contract decided
and put it behind a feature flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 15/10/2024
Developer Name: Ishan Veer
Issue Ticket Number
Description
Previously all the data was being fetched at once which can cause performance issues. So things I worked on:
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
Test Coverage
Screenshot 1
Additional Notes
Currently testing it with mock data because API is still not paginated.