Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev To Main Sync #892

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Dev To Main Sync #892

merged 3 commits into from
Oct 17, 2024

Conversation

rishirishhh
Copy link
Member

@rishirishhh rishirishhh commented Oct 16, 2024

Date: 16/10/2024

Developer Name: Kavya Rishi


Issue Ticket Number

#875
#855

PRs going in this sync

#884
#863

Screencasts

Screencast.from.16-10-24.08.26.59.PM.IST.webm

* enhancement: added shimmer effect

* added e2e tests

* removed comments from style.css

* Update tests.yml

This will be removed eventually

* Update tests.yml

* added uniform design to the card

* fixed small error
@rishirishhh rishirishhh marked this pull request as ready for review October 16, 2024 14:58
* fix: Added footer contaning repo link for every webpage

* fix: Added footer contaning repo link for every webpage

* Enhancement: Added tests for new URLs

* Enhancement: Added tests for new URLs

* Fix: Removed Live URLs which do not have footer from testing

* Enhancement: Fixed position for footer

* fix: removed commented content

* Enhancement: Used adata-test-id instead of class/id

* Fix: footer position styling

* Fix: changes using data-test-id

* Fix: Prettier changes

* Fix: minor bug fixes

* Enhancement: Made reusable footer component

* Enhancement: Replaced footer of webpages with footer component

* Fix: Minor fixes

* Fix: Removed additional footers

* Fix: Removed additional footers

* Fix: Removed additional footers

* Fix: Added styles in global stylesheet

* Fix: Minor fix of stylesheet

* Fix: Test timeout error

* Fix: Using data-test-id instead of classes

---------

Co-authored-by: Vinit khandal <111434418+vinit717@users.noreply.github.com>
Copy link

cloudflare-workers-and-pages bot commented Oct 16, 2024

Deploying dashboard-rds with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2e83ff6
Status: ✅  Deploy successful!
Preview URL: https://21171e8b.dashboard-rds.pages.dev
Branch Preview URL: https://develop.dashboard-rds.pages.dev

View logs

@shantanu-02
Copy link
Contributor

shantanu-02 commented Oct 16, 2024

Date: 17/10/2024

Developer Name: shantanu-pawar-1

Issue Ticket Number

#855

PRs going in this sync

#863

Screencasts

Screenshot (118)
Screenshot (119)
Screenshot (120)

Here is the proof of the footer working fine on staging site.

@iamitprakash iamitprakash merged commit 1a2b13a into main Oct 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants