Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed buttons to mark oneself as idle or active #432

Merged
merged 5 commits into from
Jul 16, 2023
Merged

Removed buttons to mark oneself as idle or active #432

merged 5 commits into from
Jul 16, 2023

Conversation

manish591
Copy link
Contributor

@manish591 manish591 commented Jul 7, 2023 •
edited
Loading

Issue

closes #412
closes #441

What is Change?

  1. Remove user action for marking user idle and active
  2. Added userStatusFlag feature flag.
  3. Updated tests

Before/After Changes

Before:

Screenshot (70)

After:

Screenshot (69)

Screenshot (68)

Screenshot (67)

@netlify
Copy link

netlify bot commented Jul 7, 2023 •
edited
Loading

✅ Deploy Preview for staging-my ready!

Name Link
🔨 Latest commit fa37e1a
🔍 Latest deploy log https://app.netlify.com/sites/staging-my/deploys/64b27f0f8411a600089b1f17
😎 Deploy Preview https://deploy-preview-432--staging-my.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@manish591 manish591 marked this pull request as ready for review July 8, 2023 15:31
@manish591 manish591 requested a review from heyrandhir July 8, 2023 15:31
@heyrandhir heyrandhir changed the title feat-removed buttons to mark user idle and active Removed buttons to mark oneself as idle or active Jul 9, 2023
heyrandhir
heyrandhir previously approved these changes Jul 10, 2023
View reviewed changes
sahsisunny
sahsisunny approved these changes Jul 16, 2023
View reviewed changes
Copy link
Member

@sahsisunny sahsisunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heyrandhir heyrandhir merged commit 321264f into Real-Dev-Squad:develop Jul 16, 2023
5 checks passed
@heyrandhir heyrandhir mentioned this pull request Jul 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sahsisunny sahsisunny sahsisunny approved these changes

@heyrandhir heyrandhir heyrandhir approved these changes

@vinit717 vinit717 Awaiting requested review from vinit717

@shubhamsinghbundela shubhamsinghbundela Awaiting requested review from shubhamsinghbundela

Assignees

@manish591 manish591

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add userStatusFlag feature flag when updating user status Remove the user action of marking user IDLE
3 participants
@manish591 @sahsisunny @heyrandhir