added feature flag on new-signup flow #447
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for staging-my ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
2 tasks
DeRaowl
suggested changes
Jul 15, 2023
| > | ||
| {{if (eq @currentStep 'username') 'Submit' 'Next'}} | ||
| </Button> | ||
| {{#if @dev}} |
There was a problem hiding this comment.
Can we have a correct naming convention for this? @dev don't justify the cause
| @@ -65,6 +68,15 @@ export default class NewSignUpController extends Controller { | |||
| } | |||
|
|
|||
| @action async signup() { | |||
| let roles; | |||
|
|
|||
| if (this.dev) { | |||
There was a problem hiding this comment.
Suggested change
| if (this.dev) { | |
| if (this.isDevMode) { |
| this.currentStep = this.LAST_STEP; | ||
| } else { | ||
| this.analytics.trackEvent(NEW_SIGNUP_FLOW.UNABLE_TO_SIGNUP); | ||
| if (this.dev) { |
There was a problem hiding this comment.
Suggested change
| if (this.dev) { | |
| if (this.isDevMode) { |
| } else { | ||
| this.analytics.trackEvent(NEW_SIGNUP_FLOW.UNABLE_TO_SIGNUP); | ||
| if (this.dev) { | ||
| fetch(`${BASE_API_URL}/users/self`, { |
| @@ -1,4 +1,4 @@ | |||
| {{page-title "New Sign Up"}} | |||
| {{page-title 'New Sign Up'}} | |||
| @@ -11,6 +11,7 @@ | |||
| <NewSignup::Input | |||
| @onClick={{this.changeStepToThree}} | |||
| @currentStep={{this.currentStep}} | |||
| @dev={{this.dev}} | |||
| @@ -21,21 +22,46 @@ | |||
| <NewSignup::Input | |||
| @onClick={{this.changeStepToFour}} | |||
| @currentStep={{this.currentStep}} | |||
| @dev={{this.dev}} | |||
| /> | ||
| {{/if}} | ||
| {{/if}} | ||
|
|
There was a problem hiding this comment.
Can we change @dev to some more meaningful name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #426
What is the change?
Added feature flag on new-signup flow
Before / After Change Screenshots
Before feature flag and after feature flag
chrome_tp53Ln9HYw.mp4