-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added feature flag on new-signup flow #447
Conversation
✅ Deploy Preview for staging-my ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
> | ||
{{if (eq @currentStep 'username') 'Submit' 'Next'}} | ||
</Button> | ||
{{#if @dev}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have a correct naming convention for this? @dev don't justify the cause
@@ -65,6 +68,15 @@ export default class NewSignUpController extends Controller { | |||
} | |||
|
|||
@action async signup() { | |||
let roles; | |||
|
|||
if (this.dev) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (this.dev) { | |
if (this.isDevMode) { |
this.currentStep = this.LAST_STEP; | ||
} else { | ||
this.analytics.trackEvent(NEW_SIGNUP_FLOW.UNABLE_TO_SIGNUP); | ||
if (this.dev) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (this.dev) { | |
if (this.isDevMode) { |
} else { | ||
this.analytics.trackEvent(NEW_SIGNUP_FLOW.UNABLE_TO_SIGNUP); | ||
if (this.dev) { | ||
fetch(`${BASE_API_URL}/users/self`, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we not using Ember Data
@@ -1,4 +1,4 @@ | |||
{{page-title "New Sign Up"}} | |||
{{page-title 'New Sign Up'}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change in quotes?
@@ -11,6 +11,7 @@ | |||
<NewSignup::Input | |||
@onClick={{this.changeStepToThree}} | |||
@currentStep={{this.currentStep}} | |||
@dev={{this.dev}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name can be more precise
@@ -21,21 +22,46 @@ | |||
<NewSignup::Input | |||
@onClick={{this.changeStepToFour}} | |||
@currentStep={{this.currentStep}} | |||
@dev={{this.dev}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
/> | ||
{{/if}} | ||
{{/if}} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change @dev to some more meaningful name
Closes #426
What is the change?
Added feature flag on new-signup flow
Before / After Change Screenshots
Before feature flag and after feature flag
chrome_tp53Ln9HYw.mp4