Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progress bar UX Improvements #449

Merged
merged 18 commits into from
Jul 28, 2023
Merged

Progress bar UX Improvements #449

merged 18 commits into from
Jul 28, 2023

Conversation

Ajeyakrishna-k
Copy link
Contributor

@Ajeyakrishna-k Ajeyakrishna-k commented Jul 19, 2023 •
edited
Loading

Issue: #436

Description:

  1. Created a new component for progress bar
  2. Currently under feature flag.
  3. Also added two extra dependencies ember-modifiers and lodash

video:

Screen.Recording.2023-07-21.at.12.05.59.AM.mov

Test Coverage:
Screenshot 2023-07-21 at 10 13 55 PM

@netlify
Copy link

netlify bot commented Jul 19, 2023 •
edited
Loading

✅ Deploy Preview for staging-my ready!

Name Link
🔨 Latest commit 5a24ab9
🔍 Latest deploy log https://app.netlify.com/sites/staging-my/deploys/64c15455ef67530008b98ea8
😎 Deploy Preview https://deploy-preview-449--staging-my.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Ajeyakrishna-k Ajeyakrishna-k marked this pull request as ready for review July 21, 2023 03:33
yesyash
yesyash requested changes Jul 23, 2023
View reviewed changes
app/components/progress-bar.hbs Outdated Show resolved Hide resolved
app/components/progress-bar.js Outdated Show resolved Hide resolved
app/components/progress-bar.js Outdated Show resolved Hide resolved
app/modifiers/focus-when.js Show resolved Hide resolved
app/modifiers/focus-when.js Show resolved Hide resolved
app/styles/progress-bar.css Outdated Show resolved Hide resolved
prakashchoudhary07
prakashchoudhary07 reviewed Jul 24, 2023
View reviewed changes
app/components/progress-bar.js Outdated Show resolved Hide resolved
app/utils/debounce.js Outdated Show resolved Hide resolved
app/modifiers/focus-when.js Show resolved Hide resolved
Pratiyushkumar
Pratiyushkumar reviewed Jul 26, 2023
View reviewed changes
Copy link

@Pratiyushkumar Pratiyushkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should also handle it after the user has stopped updating the progress on the progress bar then the progress bar should get disabled

@Ajeyakrishna-k
Copy link
Contributor Author

you should also handle it after the user has stopped updating the progress on the progress bar then the progress bar should get disabled

it has that functionality.

@Ajeyakrishna-k Ajeyakrishna-k merged commit 975ccad into Real-Dev-Squad:develop Jul 28, 2023
5 checks passed
@Ajeyakrishna-k Ajeyakrishna-k deleted the progress-bar branch July 28, 2023 12:49
@Ajeyakrishna-k Ajeyakrishna-k mentioned this pull request Jul 29, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pratiyushkumar Pratiyushkumar Pratiyushkumar left review comments

@prakashchoudhary07 prakashchoudhary07 prakashchoudhary07 approved these changes

@yesyash yesyash yesyash approved these changes

@harshith-venkatesh harshith-venkatesh Awaiting requested review from harshith-venkatesh

@bharati-21 bharati-21 Awaiting requested review from bharati-21

@vinit717 vinit717 Awaiting requested review from vinit717

@iamitprakash iamitprakash Awaiting requested review from iamitprakash

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ajeyakrishna-k @prakashchoudhary07 @yesyash @Pratiyushkumar