Promise base from nloewen [WIP] #87
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows code which can handle any type of promise. Creating IPromiseBase allows IPromise, IPromise<int>, and IPromise<MyFunClass> to all be treated identically, without creating code branches for each. The IPromiseBase interface is implemented explicitly, which avoids creating ambiguous functions. Additionally, the Promise_Base class allows for a decent amount of code reuse between generic and non-generic promises.
ericnewton76
force-pushed
the
promise_base
branch
from
5ce25d6 to
b3dcc3a
Compare
|
of note, should formally remove packages folder from repo and .nuget folder |
|
Hello? Anybody here to merge this in? Or at least review? |
|
Hey, sorry it's taken me a while to get back to you. I've been out of office the past week and have also had quite a few other projects going on. Overall I think it looks like a great addition and it looks like all the tests pass. The only thing I think I'd consider changing is renaming Promise_Base to PromiseBase because elsewhere we try to stick to PascalCase for class names. Promise_NonGeneric breaks this rule but that's because the underscore takes the place of a comma, so it should read as "promise, non-generic". I think in this case "promise base" makes more sense than "promise, base". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picking up where nloewen left off.
Merged all master changes into promise_base
Tests all come back fine.