Add some convenience functions to know the forking status without pee…

…king too much at the implementation
RealityETH · Nov 22, 2023 · 75e73a9 · 75e73a9
1 parent 115101d
commit 75e73a9
Show file tree

Hide file tree

Showing 3 changed files with 66 additions and 0 deletions.
diff --git a/contracts/ForkingManager.sol b/contracts/ForkingManager.sol
@@ -63,6 +63,19 @@ contract ForkingManager is IForkingManager, ForkableStructure {
         ForkableStructure.initialize(address(this), _parentContract);
     }
 
+    function isForkingInitiated() external view returns (bool) {
+        return (executionTimeForProposal > 0);    
+    } 
+
+    function isForkingExecuted() external view returns (bool) {
+        return (children[0] != address(0) || children[1] != address(0));
+    }
+
+    // TODO: If there is any other reason a fork can be prevented, eg the contract can be frozen by governance, add it here.
+    function canFork() external view returns (bool) {
+        return (executionTimeForProposal == 0);
+    }
+
     /**
      * @notice function to initiate and schedule the fork
      * @param _disputeData the dispute contract and call to identify the dispute

diff --git a/contracts/interfaces/IForkingManager.sol b/contracts/interfaces/IForkingManager.sol
@@ -30,6 +30,11 @@ interface IForkingManager is IForkableStructure {
     function globalExitRoot() external returns (address);
     function arbitrationFee() external returns (uint256);
     function disputeData() external returns (bool isL1, address disputeContract, bytes32 disputeContent);
+    function executionTimeForProposal() external returns (uint256);
+
+    function isForkingInitiated() external returns (bool);
+    function isForkingExecuted() external returns (bool);
+    function canFork() external returns (bool);
 
     // Struct that holds an address pair used to store the new child contracts
     struct AddressPair {

diff --git a/test/ForkingManager.t.sol b/test/ForkingManager.t.sol
@@ -198,6 +198,54 @@ contract ForkingManagerTest is Test {
         );
     }
 
+    function testForkingStatusFunctions() public {
+
+        assertFalse(forkmanager.isForkingInitiated());
+        assertFalse(forkmanager.isForkingExecuted());
+        assertTrue(forkmanager.canFork());
+
+        // Mint and approve the arbitration fee for the test contract
+        forkonomicToken.approve(address(forkmanager), arbitrationFee);
+        vm.prank(address(this));
+        forkonomicToken.mint(address(this), arbitrationFee);
+
+        vm.expectEmit(true, true, true, true, address(forkonomicToken));
+        emit Transfer(
+            address(this),
+            address(forkmanager),
+            uint256(arbitrationFee)
+        );
+
+        forkmanager.initiateFork(
+            IForkingManager.DisputeData({
+                disputeContract: disputeContract,
+                disputeContent: disputeContent,
+                isL1: isL1
+            }),
+            IForkingManager.NewImplementations({
+                bridgeImplementation: newBridgeImplementation,
+                zkEVMImplementation: newZkevmImplementation,
+                forkonomicTokenImplementation: newForkonomicTokenImplementation,
+                forkingManagerImplementation: newForkmanagerImplementation,
+                globalExitRootImplementation: newGlobalExitRootImplementation,
+                verifier: newVerifierImplementation,
+                forkID: newForkID
+            })
+        );
+
+        assertTrue(forkmanager.isForkingInitiated());
+        assertFalse(forkmanager.isForkingExecuted());
+        assertFalse(forkmanager.canFork());
+
+        vm.warp(block.timestamp + forkmanager.forkPreparationTime() + 1);
+        forkmanager.executeFork();
+
+        assertTrue(forkmanager.isForkingInitiated());
+        assertTrue(forkmanager.isForkingExecuted());
+        assertFalse(forkmanager.canFork());
+
+    }
+
     function testInitiateForkChargesFees() public {
         // Call the initiateFork function to create a new fork
         vm.expectRevert(bytes("ERC20: insufficient allowance"));