Fix lintjs errors and activate it in CI #164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmundedgar
reviewed
Jan 5, 2024
There was a problem hiding this comment.
Is this mostly just running the linter and letting it do stuff automatically because I have the unmerged refactoring on the branch refactorDeploymentScripts and it's going to be a pita to resolve them so it would be easier to merge them first, or run the linter on them then merge them
|
Hm... quite some things needed manual code changes to resolve the issues. But feel free to incoroprate the changes into your PR. Then I don't mind. |
|
OK, I'll incorporate them. |
|
replaced by #175 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No logical changes, just formatting and activiating CI checks