Remove submodules except for the forge standard libraries and rely on npm #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ones in package.json used by hardhat
josojo
approved these changes
Feb 24, 2024
|
The difference between v3.0.0-RealityETH just seems to be the package name etc, ie the version we're referencing in npm lacks this commit: We want to manage this with a tag, right? (I think specifying the version one way or another would be the sane thing to do it's, less likely to cause trouble with caches and things). If so I can do another PR to tag the current main as v3.0.1-RealityETH and update to that. Alternatively maybe we just pin the commit for the time being, rather than tagging every time, that would save us a step. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the need to have duplicate settings in package.json (for hardhat) and .gitmodules / remappings.txt (for forge) by making forge use the hardhat method. It also lets us use git submodules less which is good because they tend to confuse the hell out of everyone.