Remove the copy-pasted reality.eth fork of reality.eth v3, replace it with reality.eth v4 via npm #250
Conversation
There was a problem hiding this comment.
Looks good. I just think that the balancerHOlder should not go into MinimalAdjudicationFramework, but into AdjudicationFrameworkREquests.
I think you can also pull the balanceHolder contract in from the NPM package and reuse the code, if you want and wanna save some lines
| @@ -56,6 +61,8 @@ contract MinimalAdjudicationFramework is IMinimalAdjudicationFramework { | |||
| uint256 public forkActivationDelay; | |||
| IRealityETH public realityETH; | |||
|
|
|||
| mapping(address => uint256) public balanceOf; | |||
There was a problem hiding this comment.
I don't get that change. Maybe you wanna add a comment why this is needed?
it seems the balanceOf() is never set to a positive value, can only be withdrawn. Strange
There was a problem hiding this comment.
If this is only for the other contracts to inherit I think it should be put into the parent contract, or at least explained.
There was a problem hiding this comment.
Ah, you're right, it's only used in the pull version. I'll move the whole thing to there.
There was a problem hiding this comment.
ok, I moved it to the pull version that allowed me to delete that stuff and just inherit the whole thing from the BalanceHolder in @reality.eth/contracts
… with reality.eth v4 via npm
edmundedgar
force-pushed
the
prUseCommonRealityETH
branch
from
55daeac
to
1697fbd
Compare
No description provided.