Fork5-rebasing #24
Closed
Fork5-rebasing #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npm run audit
|
This is their code and you're just merging it in, right? Should I review the specific changes? |
edmundedgar
reviewed
Aug 21, 2023
| console.log(`npx hardhat verify --constructor-args upgrade/arguments.js ${newImplPolygonAddress} --network ${process.env.HARDHAT_NETWORK}\n`); | ||
| console.log("Copy the following constructor arguments on: upgrade/arguments.js \n", upgrade.constructorArgs) | ||
| console.log('Copy the following constructor arguments on: upgrade/arguments.js \n', upgrade.constructorArgs); |
There was a problem hiding this comment.
Wouldn't this print a literal \n when we want a new line?
There was a problem hiding this comment.
In my terminal, it prints a new line.
|
Yes, its a 1to1 merge from their code. The only major change is the difference in function signature of verifyBatches with the different proof handover. No, nothing specific to review, just whether it makes sense all together. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a rebase to the newest fork.5 contracts of the polygon contracts. I will keep it open until the polygon team merges it to main