Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebased pol yf6 #28

Merged
merged 27 commits into from
Dec 18, 2023
Merged

Rebased pol yf6 #28

merged 27 commits into from
Dec 18, 2023

Conversation

josojo
Copy link
Collaborator

@josojo josojo commented Dec 11, 2023

No description provided.

krlosMata and others added 27 commits October 17, 2023 11:54
…egen-upgrade-info

Feature/regen upgrade info
@josojo josojo requested a review from edmundedgar December 12, 2023 06:20
@@ -48,8 +48,8 @@ contract FflonkVerifier {
uint256 constant w8_7 = 8613538655231327379234925296132678673308827349856085326283699237864372525723;

// Verifier preprocessed input C_0(x)·[1]_1
uint256 constant C0x = 10330861150616913541207360924312278787207684679419670167996002791305440821704;
uint256 constant C0y = 14244524222232642134204580826860575549922689127759263461569792153452315036880;
uint256 constant C0x = 7436841426934271843999872946312645822871802402068881571108027575346498207286;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea what this is but do we mean to change it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the new verifier needs an update for the numbers.

It's because the circuits of the system changed

Copy link

@edmundedgar edmundedgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine with the caveat that I have no idea what
uint256 constant C0x is all about so I can't say whether that part looks correct

@josojo josojo merged commit 98773c5 into main Dec 18, 2023
1 check passed
@josojo josojo deleted the rebasedPolYf6 branch December 18, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants