Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi component parsing to support XY-datasets #31

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jgoedeke
Copy link

@jgoedeke jgoedeke commented Nov 5, 2024

Closes #30

This pull request adds the two components to the parsing of a channel. This way XY-datasets can be parsed and xdata and ydata is properly set.
It utilizes the unused imc_object.hpp to cast every metadata key into a proper object. This may create a slight overhead because all parameters are parsed, but improves the readability IMO. It also implements the 6byte unsigned long datatype. Finally the buffer-size is exposed to the python interface to enable calculation of the file timespan without parsing the buffer.

There is a naming inconsistency in xoffset because this variable name was used for the x0 parameter in normal datasets before but is applicable to the offset value of the x component as well. I renamed the x0 parameter variabel to xstart but kept the name xoffset in the python interface (get_info())

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for multi component datafields (XY-dataset)
1 participant