Refactor if statement

Recruitee · Apr 18, 2023 · bd43ed4 · bd43ed4
1 parent 402e3d3
commit bd43ed4
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/lib/plausible_web/controllers/api/external_controller.ex b/lib/plausible_web/controllers/api/external_controller.ex
@@ -168,11 +168,7 @@ defmodule PlausibleWeb.Api.ExternalController do
  defp is_bot?(%UAInspector.Result.Bot{}), do: true
 
  defp is_bot?(%UAInspector.Result{client: %UAInspector.Result.Client{name: "Headless Chrome"}}) do
- if Application.get_env(:plausible, :system_environment) in ["staging", "rc"] do
- false
- else
- true
- end
+ Application.get_env(:plausible, :system_environment) not in ["staging", "rc"]
  end
 
  defp is_bot?(_), do: false