Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump language version and dependencies #24

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Bump language version and dependencies #24

merged 2 commits into from
Oct 25, 2023

Conversation

rdk08
Copy link

@rdk08 rdk08 commented Oct 25, 2023

No description provided.

@rdk08 rdk08 requested a review from jacooobi October 25, 2023 07:52
@rdk08 rdk08 self-assigned this Oct 25, 2023
@jacooobi
Copy link
Member

Woah quite a few tests are failing. Was it always like this or latest update causes this? Also, what kind of errors are we getting now?

@rdk08
Copy link
Author

rdk08 commented Oct 25, 2023

Woah quite a few tests are failing. Was it always like this or latest update causes this? Also, what kind of errors are we getting now?

Yeah, the tests were not updated after the changes in router (when most of the routes were commented out). Most of the test are failing due to that. The other reason is Clickhouse setup (tables that don't support sampling).

@rdk08 rdk08 merged commit cf3db2e into master Oct 25, 2023
0 of 2 checks passed
@rdk08 rdk08 deleted the bump-dependencies branch October 25, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants