Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add contract_id field #26

Closed
wants to merge 1 commit into from
Closed

Add contract_id field #26

wants to merge 1 commit into from

Conversation

rdk08
Copy link

@rdk08 rdk08 commented Nov 8, 2023

No description provided.

@rdk08 rdk08 requested a review from jacooobi November 8, 2023 18:13
@rdk08 rdk08 self-assigned this Nov 8, 2023
jacooobi
jacooobi reviewed Nov 9, 2023
View reviewed changes
Copy link
Member

@jacooobi jacooobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't we agreed with integrations that contracts will be passed in product_id as well?

@rdk08
Copy link
Author

rdk08 commented Nov 9, 2023

Yes, as far as I remember there were plans to send contract_id separately, but indeed, on one of the last calls we agreed that we can reuse product_id. Closing.

@rdk08 rdk08 closed this Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacooobi jacooobi jacooobi left review comments

Assignees

@rdk08 rdk08

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rdk08 @jacooobi