Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add single tree repo updates #2769

Merged

Conversation

loadtheaccumulator
Copy link
Collaborator

@loadtheaccumulator loadtheaccumulator commented Dec 31, 2024

Description

Adds update of a single tree in an existing repo

FIXES: HMS-4121

Type of change

What is it?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Tests update
  • Refactor

@loadtheaccumulator loadtheaccumulator changed the title Pulp update urls Add single tree repo updates Dec 31, 2024
Copy link
Contributor

mergify bot commented Dec 31, 2024

This pull request is now in conflicts. Could you fix it @loadtheaccumulator? 🙏

@mergify mergify bot added the conflict Code conflict label Dec 31, 2024
@mergify mergify bot added new feature New feature and removed conflict Code conflict labels Dec 31, 2024
@loadtheaccumulator loadtheaccumulator marked this pull request as draft December 31, 2024 23:11
@loadtheaccumulator
Copy link
Collaborator Author

loadtheaccumulator commented Dec 31, 2024

Fixing a bug preventing 2nd+ update from using the single tree. The first update works, but second update on get lost because of the way AWS S3 repos stored before. Fix on the way post holiday. Setting this to draft until then.

@lzap
Copy link
Collaborator

lzap commented Jan 7, 2025

Looks good.

@loadtheaccumulator loadtheaccumulator force-pushed the pulp_update_urls branch 5 times, most recently from 7e6984a to e3f6e24 Compare January 10, 2025 17:46
@loadtheaccumulator loadtheaccumulator marked this pull request as ready for review January 10, 2025 17:48
lzap
lzap previously approved these changes Jan 13, 2025
Copy link
Collaborator

@lzap lzap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment regarding the timeout - I suggest to make it even longer.

pkg/jobs/memory.go Outdated Show resolved Hide resolved
pkg/models/commits.go Outdated Show resolved Hide resolved
@mergify mergify bot dismissed lzap’s stale review January 13, 2025 18:17

New commit(s) added, removing existing approval(s)

@loadtheaccumulator loadtheaccumulator force-pushed the pulp_update_urls branch 4 times, most recently from b7ead08 to 569a9da Compare January 13, 2025 18:21
Signed-off-by: Jonathan Holloway <jholloway@redhat.com>
@loadtheaccumulator
Copy link
Collaborator Author

/retest

@loadtheaccumulator
Copy link
Collaborator Author

/retest

@loadtheaccumulator loadtheaccumulator merged commit f9a773b into RedHatInsights:main Jan 13, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants