Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to cleanup DVO database #281

Merged
merged 8 commits into from
Nov 24, 2023
Merged

Ability to cleanup DVO database #281

merged 8 commits into from
Nov 24, 2023

Conversation

tisnik
Copy link
Collaborator

@tisnik tisnik commented Nov 24, 2023

Description

  • Ability to cleanup DVO database
  • 100% unit test coverage for new code

Fixes https://issues.redhat.com/browse/CCXDEV-12163

Type of change

  • New feature (non-breaking change which adds functionality)
  • Unit tests (no changes in the code)

Testing steps

To be checked on CI.

Checklist

  • make before_commit passes
  • updated documentation wherever necessary
  • added or modified tests if necessary
  • updated schemas and validators in insights-data-schemas in case of input/output change

@tisnik tisnik marked this pull request as draft November 24, 2023 10:56
@tisnik tisnik marked this pull request as ready for review November 24, 2023 11:48
@tisnik tisnik merged commit edff7e0 into RedHatInsights:master Nov 24, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juandspy juandspy juandspy approved these changes

@epapbak epapbak epapbak approved these changes

@Bee-lee Bee-lee Awaiting requested review from Bee-lee

@joselsegura joselsegura Awaiting requested review from joselsegura

@matysek matysek Awaiting requested review from matysek

@JiriPapousek JiriPapousek Awaiting requested review from JiriPapousek

@Jakub007d Jakub007d Awaiting requested review from Jakub007d

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tisnik @epapbak @juandspy