Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use WHERE EXISTS instead of USING for lib/pq #330

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Use WHERE EXISTS instead of USING for lib/pq #330

merged 1 commit into from
Jul 9, 2024

Conversation

epapbak
Copy link
Collaborator

@epapbak epapbak commented Jul 9, 2024 •
edited
Loading

Description

Running the cleaner locally might fail due to the USING clause depending on version of lib/pq

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing steps

CI

Checklist

  • make before_commit passes
  • updated documentation wherever necessary
  • added or modified tests if necessary
  • updated schemas and validators in insights-data-schemas in case of input/output change

@epapbak epapbak merged commit 65d25ae into RedHatInsights:master Jul 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juandspy juandspy juandspy approved these changes

@tisnik tisnik Awaiting requested review from tisnik

@Bee-lee Bee-lee Awaiting requested review from Bee-lee

@joselsegura joselsegura Awaiting requested review from joselsegura

@matysek matysek Awaiting requested review from matysek

@JiriPapousek JiriPapousek Awaiting requested review from JiriPapousek

@Jakub007d Jakub007d Awaiting requested review from Jakub007d

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@epapbak @juandspy