Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSIDB-3579: Handle models without manager #860

Merged
merged 1 commit into from
Dec 13, 2024
Merged

OSIDB-3579: Handle models without manager #860

merged 1 commit into from
Dec 13, 2024

Conversation

MrMarble
Copy link
Member

@MrMarble MrMarble commented Dec 13, 2024

From my testing locally, all content-types had a manager to acces the model.objects field, but on stage, this task is failing because there's at least one model without a manager.

model_class.objects.filter(
AttributeError: 'NoneType' object has no attribute 'objects'

I've added a log message to report the error and continue the loop.

@MrMarble MrMarble added the technical For PRs that introduce changes not worthy of a CHANGELOG entry label Dec 13, 2024
@MrMarble MrMarble requested a review from a team December 13, 2024 11:54
@MrMarble MrMarble self-assigned this Dec 13, 2024
Copy link
Contributor

@costaconrado costaconrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MrMarble MrMarble added this pull request to the merge queue Dec 13, 2024
Merged via the queue into master with commit d5598e6 Dec 13, 2024
13 checks passed
@MrMarble MrMarble deleted the OSIDB-3579 branch December 13, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical For PRs that introduce changes not worthy of a CHANGELOG entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants