Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subscription plans list endpoint support #170

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Subscription plans list endpoint support #170

merged 3 commits into from
Jul 8, 2024

Conversation

burythehammer
Copy link
Contributor

Support for the endpoint fixed/plans/subcriptions/{subscriptionId} in the Redis Cloud API, with accompanying unit test.

@burythehammer burythehammer requested a review from JohnSharpe July 4, 2024 16:04
@CLAassistant
Copy link

CLAassistant commented Jul 4, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@burythehammer burythehammer added enhancement New feature or request good first issue Good for newcomers go Pull requests that update Go code labels Jul 4, 2024
JohnSharpe
JohnSharpe reviewed Jul 4, 2024
View reviewed changes
client.go Outdated Show resolved Hide resolved
JohnSharpe
JohnSharpe approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@JohnSharpe JohnSharpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! A few comments but no showstoppers

@burythehammer burythehammer force-pushed the feature/subscription-plans-list branch from b62af54 to 3b121c7 Compare July 8, 2024 08:08
@JohnSharpe JohnSharpe merged commit 8a5814f into main Jul 8, 2024
3 checks passed
@JohnSharpe JohnSharpe deleted the feature/subscription-plans-list branch July 8, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnSharpe JohnSharpe JohnSharpe approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request go Pull requests that update Go code good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@burythehammer @CLAassistant @JohnSharpe