[4.3] Cherry-picks for the 4.3 (4.3.1) branch - 1st core bugs batch #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Rect of texture to take window and stretch transform into account. There is no need for `viewport_attach_to_screen` for embedded windows, since their display is handled via `Viewport::_sub_window_update`. (cherry picked from commit 0eff41d)
(cherry picked from commit 6516ca6)
(cherry picked from commit c8b697c)
(cherry picked from commit cee0e66)
(cherry picked from commit a84c480)
(cherry picked from commit 3e0d3c4)
Variant operators for String formatting and "in" could result in errors, which would return from validated_evaluate without assigning r_ret. This would cause scripts using the return value from these operators to get results from previously run code. Updated to return the original String value in the String formatting case, and false for "in" when an error occurs. (cherry picked from commit 714357e)
(cherry picked from commit 2d1dd41)
(cherry picked from commit c8acf56)
- The main thread function and the collaborative wait functions have a much more similar structure than earlier, which yields (pun intended) better maintainability. - Also, there are not assertions anymore about the reason for ending a wait being valid, because spurious awakes can happen and so the assert would fail without that indicating an issue. (cherry picked from commit 2640960)
(cherry picked from commit 2a483fa)
Spartan322
force-pushed
the
4.3.1-cherry-pick/bugs-core
branch
from
c2724bc to
ff73c52
Compare
Signed-off-by: Yevhen Babiichuk (DustDFG) <dfgdust@gmail.com> (cherry picked from commit ee5d908)
…on for Embree. (cherry picked from commit 4089a6c)
A few missed last pass and one incorrect from that pass (cherry picked from commit 2693808)
(cherry picked from commit 4988fa1)
… is found (cherry picked from commit f79b972)
(cherry picked from commit 7a25173)
(cherry picked from commit 6cf9af2)
Prior to this `..\..\texture.png` was incorrectly simplified to `texture.png` (cherry picked from commit 964e2b3)
(cherry picked from commit a6c5373)
Spartan322
force-pushed
the
4.3.1-cherry-pick/bugs-core
branch
from
ff73c52 to
2f0f68c
Compare
decryptedchaos
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core Bug PRs:
Windowgodotengine/godot#80121Variantoperator failure godotengine/godot#95166atr_n()behavior when auto translation is disabled godotengine/godot#97624inoperator for Arrays and Dictionaries godotengine/godot#98363get_configuration_warningsmethods godotengine/godot#98951get_thread_count()to1if single threaded godotengine/godot#99416..in simplify_path godotengine/godot#100075DirAccess::unlink()not updating the IDBFS godotengine/godot#100221Extra PRs:
initialize_refgodotengine/godot#94679String::simplify_pathhandling of relative paths to parent dir (../), fixes relative shader includes godotengine/godot#95184