Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slider #354

Closed
wants to merge 5 commits into from
Closed

Fix slider #354

wants to merge 5 commits into from

Conversation

yibeichan
Copy link
Contributor

changes made

  1. create slider based on minValue and maxValue rather than choices, the default setting is from 0 to 100
  2. the current schema choices generation can remain it is now, we read choices["name"] for minLabel, midLabel, and maxLabel

looks like this
image

@yibeichan yibeichan requested a review from satra November 22, 2024 22:07
@yibeichan
Copy link
Contributor Author

wait, my previous commits (from the isVis issue) are also here... i need to remove them

@yibeichan
Copy link
Contributor Author

this branch messed up, i'm closing it and starting a new one

@yibeichan yibeichan closed this Nov 25, 2024
@yibeichan yibeichan deleted the fix-slider branch November 25, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant