Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve APCPieGraphViewDelegate #127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

p2
Copy link
Member

@p2 p2 commented Aug 3, 2015

To allow one delegate to handle more than one pie graph.

@YuanZhu-apple
Copy link
Member

If this API change requires the apps to change?

And we have been working on a graphing library in ResearchKit: ResearchKit/ResearchKit#178
Have you seen it?

@rsanchezsaez
Copy link

Yeah, this change requires a trivial method rename in the apps using the APCPieGraph class. See comment by @p2 below. ;-)

I think this is nice to have. I'll make this change to the ResearchKit graph branch as well.

@p2
Copy link
Member Author

p2 commented Aug 3, 2015

Thanks @YuanZhu-apple , hope the RK branch gets pulled in soon!

It could potentially require apps to change if they create their own pie chart delegates. One implementation is in AppCore (APCActivityTrackingStepViewController) so if the apps just use it then there will be no changes.

Erin-Mounts added a commit to Erin-Mounts/AppCore that referenced this pull request Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants