Remove remaining DRF imports and uninstall it #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ninja` doesn't expose its pagination limit, so I just set it explicitly in `settings.py` and read from that setting. We should refactor this to use ninja's built-in pagination support instead of manually paginating
The entire codebase has been migrated to django-ninja, so we don't need this dependency anymore.
This is also unused, and has been superseded by ninja's built-in filtering capabilities.
BryonLewis
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #234, we are completely converted to ninja. This PR removes some remaining loose ends/DRF imports and uninstalls the dependencies from our poetry lockfile.