Search component

[marySalvi]

Components Added:

• Search
• Predicate
• GeoJsonForm

Expected Functionality:
The Search component pulls in the predicate, geoJsonForm and dateRange components. With Storybook you should be able to interact with all the components however clicking search does (and should) throw an error since it makes an API call.

[mvandenburgh]

Can this comment be expanded a little to explain why it's important? It's not immediately clear to me from looking at it why it's super duper important 😄

[mvandenburgh]

Suggested change

	}export interface ResultsFilter {
	}
	export interface ResultsFilter {

[mvandenburgh]

This might just be a personal preference on my part, but when I see a function named like isXXX, I expect it to be a pure function that simply checks if something is true. This function does that, but also has the side effect of populating the geoJsonErrorMessages list.

Also, the return type should probably be boolean in all cases -

Suggested change

	const isGeoJSON = (inputText: string) => {
	try {
	JSON.parse(inputText);
	geoJsonErrorMessages.value = [];
	} catch (e) {
	geoJsonErrorMessages.value = ['Not a valid GeoJSON Polygon or MultiPolygon'];
	}
	return true;
	};
	const isGeoJSON = (inputText: string) => {
	try {
	JSON.parse(inputText);
	geoJsonErrorMessages.value = [];
	} catch (e) {
	geoJsonErrorMessages.value = ['Not a valid GeoJSON Polygon or MultiPolygon'];
	return false;
	}
	return true;
	};

[mvandenburgh]

I believe this can be simplified to

Suggested change

	const collectionIDs: number[] = [];
	// eslint-disable-next-line no-unused-expressions
	resultsFilter.value.collections?.forEach((element) => {
	if (element.id) {
	collectionIDs.push(element.id);
	}
	});
	const collectionIDs = resultsFilter.value.collections?.filter((element) => element.id).map((element) => element.id);

[waxlamp]

Unless element.id has a numeric type, in which case you might need a more specific test (against null or undefined, etc.).

[mvandenburgh]

Suggested change

	const geoJsonErrorMessages = ref(['']);
	const geoJsonErrorMessages = ref([]);

Does other code depend on this starting off with a single empty string as an element?