Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain/update CI: Conan2, CodeCov upload script, dead links #1344

Merged
merged 17 commits into from
May 6, 2024

Conversation

martukas
Copy link
Member

@martukas martukas commented May 5, 2024

Description

General CI update that ensure all builds and tests pass.

  • gui project updated to use Conan v.2, seeing as Conan v1.6 is now deprecated and many packages are not updated for it
  • using the new Codecov coverage uploader utility directly from CircleCI orbs.
  • common, controller and gui build scripts updated to no longer use codecov-cli utility but instead assume external tool is used.
  • A number of links to google docs updated to pass link checker
  • A number of google docs had access settings updated to allow public viewer access
  • Raspberry pi links excluded from link checker, as their server appears to block the crawler

Self-review checklist:

  • Self-review: looked through the Files changed tab, browsed repository in branch
  • Documentation updated - reflects changes in code, electrical or mechanical design
  • Documentation and graphics follow the documentation style guide
  • New content is linked, easily discoverable, does not require too many clicks
  • Follows other relevant parts of contributor wiki
  • PR has a descriptive name
  • Tagged relevant reviewers

Software only:

  • Follows our code style
  • Commented code, particularly in hard-to-understand areas
  • [ ] All tests pass - new and old, locally and on CI
    • Tests passing on CI and locally
    • Do not have a ventilator to deploy and test with hardware, so no integration tests performed
  • [ ] No new warnings or static check failures
    • static checks fail, but they were failing before anyways, they were never enabled on CI
  • Tests that prove fix is effective or new feature works
  • Manual tests are explained, with instructions for reproducing them

Copy link

codecov bot commented May 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 68.43%. Comparing base (1f2cabc) to head (fb3db15).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1344       +/-   ##
===========================================
+ Coverage   57.53%   68.43%   +10.90%     
===========================================
  Files         102       81       -21     
  Lines        3471     2829      -642     
  Branches      333        0      -333     
===========================================
- Hits         1997     1936       -61     
+ Misses       1474      893      -581     
Flag Coverage Δ
common ?
controller ?
gui ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
software/gui/src/gui_state_container.cpp 7.29% <0.00%> (-0.48%) ⬇️

... and 52 files with indirect coverage changes

@martukas martukas changed the title Maintain ci Maintain/update CI: Conan2, CodeCov upload script, dead links May 6, 2024
@martukas martukas marked this pull request as ready for review May 6, 2024 04:32
Copy link
Contributor

@asmodai27 asmodai27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not checked on a PROTOTYPE either but most changes do not affect THE final executables.
LGTM.

@martukas martukas merged commit 20104be into master May 6, 2024
11 of 12 checks passed
@martukas martukas deleted the maintain_ci branch May 6, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants