refactor: make AchievementType a reusable and exported model

RetroAchievements · Mar 3, 2024 · 260003d · 260003d
1 parent d9095bf
commit 260003d
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 2 deletions.
diff --git a/src/user/models/achievement-type.model.ts b/src/user/models/achievement-type.model.ts
@@ -0,0 +1,5 @@
+export type AchievementType =
+  | "progression"
+  | "win_condition"
+  | "missable"
+  | null;
diff --git a/src/user/models/dated-user-achievement.model.ts b/src/user/models/dated-user-achievement.model.ts
@@ -1,3 +1,5 @@
+import type { AchievementType } from "./achievement-type.model";
+
 export type DatedUserAchievement = {
   date: string;
   hardcoreMode: boolean;
@@ -14,5 +16,5 @@ export type DatedUserAchievement = {
   cumulScore: number;
   badgeUrl: string;
   gameUrl: string;
-  type: "progression" | "win_condition" | "missable" | null;
+  type: AchievementType;
 };
diff --git a/src/user/models/dated-user-achievements-response.model.ts b/src/user/models/dated-user-achievements-response.model.ts
@@ -1,3 +1,5 @@
+import type { AchievementType } from "./achievement-type.model";
+
 interface DatedUserAchievementResponseEntity {
   Date: string;
   HardcoreMode: string;
@@ -14,7 +16,7 @@ interface DatedUserAchievementResponseEntity {
   CumulScore: number;
   BadgeURL: string;
   GameURL: string;
-  Type: "progression" | "win_condition" | "missable" | null;
+  Type: AchievementType;
 }
 
 export type DatedUserAchievementsResponse =

diff --git a/src/user/models/index.ts b/src/user/models/index.ts
@@ -1,3 +1,4 @@
+export * from "./achievement-type.model";
 export * from "./award-type.model";
 export * from "./dated-user-achievement.model";
 export * from "./dated-user-achievements-response.model";