Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add type prop to DatedUserAchievement model #81

Merged
merged 2 commits into from
Feb 27, 2024
Merged

fix: add type prop to DatedUserAchievement model #81

merged 2 commits into from
Feb 27, 2024

Conversation

minhaferzz
Copy link
Contributor

Add the type property to DatedUserAchievement and updated unit tests.

Have it set as such to match what I saw in RAWeb here

type: "progression" | "win_condition" | "missable" | null;

@wescopeland wescopeland linked an issue Feb 26, 2024 that may be closed by this pull request
Add type to more endpoint responses #56
Closed
@wescopeland wescopeland merged commit f45d79c into RetroAchievements:main Feb 27, 2024
1 check passed
@minhaferzz minhaferzz deleted the fix-dated-user-achievement-add-type branch February 28, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wescopeland wescopeland wescopeland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add type to more endpoint responses
2 participants
@minhaferzz @wescopeland