Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: switch package manager from yarn to pnpm #94

Merged
merged 4 commits into from
May 20, 2024
Merged

chore: switch package manager from yarn to pnpm #94

merged 4 commits into from
May 20, 2024

Conversation

falsepopsky
Copy link
Contributor

@falsepopsky falsepopsky commented May 17, 2024 •
edited
Loading

Closes #92

falsepopsky
falsepopsky commented May 17, 2024
View reviewed changes
.github/workflows/main.yml Show resolved Hide resolved
.github/workflows/main.yml Show resolved Hide resolved
.prettierignore Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
@falsepopsky falsepopsky changed the title chore: switch package manager from yarn to pnpm chore: switch package manager from yarn to pnpm May 17, 2024
@falsepopsky falsepopsky changed the title chore: switch package manager from yarn to pnpm chore: switch package manager from yarn to pnpm May 17, 2024
wescopeland
wescopeland reviewed May 17, 2024
View reviewed changes
Copy link
Member

@wescopeland wescopeland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR. It mostly looks good - I have a few select pieces of feedback below.

.prettierignore Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
wescopeland
wescopeland approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@wescopeland wescopeland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wescopeland wescopeland merged commit 3600962 into RetroAchievements:main May 20, 2024
1 check passed
@falsepopsky falsepopsky deleted the pnpm branch May 20, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wescopeland wescopeland wescopeland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

switch to pnpm
2 participants
@falsepopsky @wescopeland