[EXTERNAL] Fixes Amazon subscription period parsing (#1813) by @tessmerandre #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Checklist - [x] If applicable, unit tests - [x] If applicable, create follow-up issues for `purchases-ios` and hybrids ### Motivation <!-- Why is this change required? What problem does it solve? --> Amazon subscription periods were being incorrectly parsed. https://developer.amazon.com/docs/in-app-purchasing/iap-implement-iap.html#successful-request <!-- Please link to issues following this format: Resolves #999999 --> Resolves #1771 ### Description Amazon returns annual and semiannual subscription periods as `Annual` and `SemiAnnual`. Please look at the [docs](https://developer.amazon.com/docs/in-app-purchasing/iap-implement-iap.html#successful-request) for more information.
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
vegaro
approved these changes
Aug 30, 2024
tonidero
pushed a commit
that referenced
this pull request
Sep 5, 2024
**This is an automatic release.** ### Bugfixes * [EXTERNAL] Fixes Amazon subscription period parsing (#1813) by @tessmerandre (#1828) via Toni Rico (@tonidero) ### Other Changes * [Diagnostics] Send backend_error_code in http request failures if available (#1825) via Toni Rico (@tonidero) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
purchases-iosand hybridsMotivation
Amazon subscription periods were being incorrectly parsed.https://developer.amazon.com/docs/in-app-purchasing/iap-implement-iap.html#successful-request
Resolves #1771
Description
Amazon returns annual and semiannual subscription periods as
AnnualandSemiAnnual. Please look at thedocs for more information.
Contributed by @tessmerandre