Feature: manage subscriptions modal #532
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tends it with sk2 functionality.
beylmk
reviewed
Jun 23, 2021
| } | ||
|
|
||
| @MainActor | ||
| @available(iOS 15.0, *) |
There was a problem hiding this comment.
would it potentially be possible to batch these into a single custom annotation? i can see us repeating these lines alllll over the place
There was a problem hiding this comment.
I think we'd be able to do it at the extension declaration level, and it'd apply to everything in it.
|
closing in favor of #756 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PoC.
It adds a new method,
showManageSubscriptionsModal, which will show the SK2 manage subscriptions modal if available, and otherwise will open up themanageSubscriptionsURLfrom RC.The logic is a bit more nuanced, but that's the basic stuff.
To achieve this and keep all the rest, this adds a new module
PurchasesSwift(name will absolutely change before merging), which imports all of the originalPurchases, while adding Swift extensions.I tested that this can be used from objective-c and Swift (which is a clear win over SK2), as well as macOS and iOS (SK2's version only supports iOS).
Also, this takes into account the
managementURL, so if a user purchased a subscription through Android, they'll go to the correspondingmanagementURLinstead.If there's no
managementURL, I'm currently defaulting to the native one in the OS, but that's subject to change. That also conflicts with a known bug in managementURL for purchases on HOLD status in Android.