Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include do_task() results in the summary (fix #851) #855

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kablamo
Copy link
Contributor

@kablamo kablamo commented Dec 8, 2015

Fix for #851

How to test

  • prove t/summary.t

@kablamo kablamo added this to the 1.4.0 milestone Dec 8, 2015
@kablamo kablamo added the bug Confirmed bugs label Dec 8, 2015
@krimdomu
Copy link
Contributor

Currently this crashes on my windows system (win 10, perl 5.22.0) (perl interpreter just dies)
The idea to define a parent task is nice and maybe we can extend this idea to print a tree like summary.

Also i'm not sure if we want to hide do_task calls in the summary. The difference between run_task and do_task is that run_task is used to run one task on one server to get some value in return. So the Rexfile should handle failures with this internally.

do_task on the other hand just run the task on all the defined servers so i think it is good to display those results.

@krimdomu krimdomu modified the milestones: 1.5.0, 1.4.0 Dec 19, 2015
@krimdomu
Copy link
Contributor

I'm going to add this to 1.5.0 milestone, then we can think about it and how we want to display the results.

@krimdomu krimdomu modified the milestones: backlog, 1.5.0 Mar 24, 2016
@ferki ferki added the ready An idea that is ready to be worked on label Mar 25, 2016
@ferki ferki removed this from the backlog milestone Mar 25, 2016
@ferki ferki removed the ready An idea that is ready to be worked on label Apr 25, 2016
@ferki ferki changed the title Don't include do_task() results in the summary Don't include do_task() results in the summary (fix #851) Apr 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants