perf: 🚸 Type: Refactoring, Improvement | Title: Refactoring file upload and handling in the application #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad and handling in the application Description: The changes mainly focus on refactoring the way files are uploaded and handled in the application. The changes are made in three files: 'app/api/uploadthing/core.ts', 'components/rich-text-editor/editor-setup.tsx', and 'lib/uploadthing.ts'. The changes include modifying the middleware function in 'core.ts', updating the file upload handling in 'editor-setup.tsx', and adding a new function 'uploadFiles' in 'uploadthing.ts'. Main Files Walkthrough: - app/api/uploadthing/core.ts: The middleware function in 'ourFileRouter' object has been modified. The 'getToken' function now only takes 'req' as a parameter, removing the 'secret' parameter. The 'onUploadComplete' function has been simplified and now it doesn't log any information or return any data. - components/rich-text-editor/editor-setup.tsx: The 'handleUpload' function has been renamed to 'handleUploadFile' and its implementation has been updated. It now uses the 'uploadFiles' function from 'uploadthing.ts' to upload the files. Error handling has been added to the function. The 'uploadFile' property in the 'useBlockNote' function now uses the updated 'handleUploadFile' function. - lib/uploadthing.ts: A new function 'uploadFiles' has been added by using 'generateReactHelpers' function from '@uploadthing/react/hooks'. This function is exported and used in 'editor-setup.tsx' for file upload. Improvement on text editor files upload. Now users have a much better experience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The changes mainly focus on refactoring the way files are uploaded and handled in the application. The changes are made in three files: 'app/api/uploadthing/core.ts', 'components/rich-text-editor/editor-setup.tsx', and 'lib/uploadthing.ts'. The changes include modifying the middleware function in 'core.ts', updating the file upload handling in 'editor-setup.tsx', and adding a new function 'uploadFiles' in 'uploadthing.ts'.
Main Files Walkthrough:
Improvement on text editor files upload. Now users have a much better experience.