Feature: Support IPs and multiple Subject Alt Names in the TLS certificate #190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
DOMAIN
option is a bit too restrictive, as it only allows registering one Subject Alt Name on the self-signed TLS certificate, and it must be a DNS domain. When c-lightning-REST is hosted on a machine without an associated domain these certificates cannot be used to validate the responses.The new
IP
configuration option allows setting an static IP as Subject Alt Name. Its default value is127.0.0.1
, which is backwards compatible.Additionally, I've tweaked both options to allow multiple comma-separated values, as the openssl tool also supports multiple SANs.
Examples
openssl x509 -in certs/certificate.pem -text -noout
has been used to decode these certificates.master branch, default DOMAIN:
Multi SAN PR, default DOMAIN and IP:
Multi SAN PR, custom DOMAIN and IP:
DOMAIN:
localhost,example.com,ln.example.com
IP:
127.0.0.1,1.2.3.4