Refactor of pi_3_model_b_holes #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Broke out module for standard fit M2.5 hole (m25_standard_hole) Refactored all _holes() modules to array children or fallback to M2.5 This should allow any of the hole functions to be able to accurately place mounting hardware in case designs Refactor of raspberrypi_model_b_v2_holes Finished refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support the creation of board mounts, these changes refactor the raspberry pi hole
mount functions to allow them to array child blocks to each of the mount hole positions or fall back to the original behavior of producing M2.5 standard fit holes.
example to put a transparent bolt in each hole:
board_raspberrypi_3_model_b();
raspberrypi_3_model_b_holes() %cylinder(h=10, center=true, r=1.25);