Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #892 DeviantArt not ripping full sized images #1000

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: #892 DeviantArt not ripping full sized images #1000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<groupId>com.rarchives.ripme</groupId>
<artifactId>ripme</artifactId>
<packaging>jar</packaging>
<version>1.7.67</version>
<version>1.7.68-Q0-1.0.0</version>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this back to 1.7.67

<name>ripme</name>
<url>http://rip.rarchives.com</url>
<properties>
Expand Down
2 changes: 2 additions & 0 deletions src/main/java/com/rarchives/ripme/ripper/rippers/DeviantartRipper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,8 @@ public List<String> getURLsFromJSON(JSONObject json) {
try {
String imageURL = doc.select("span").first().attr("data-super-full-img");
if (!imageURL.isEmpty() && imageURL.startsWith("http")) {
String page = doc.select("span").first().attr("href");
imageURL = smallToFull(imageURL,page);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ripping the album https://www.deviantart.com/justgenitals/gallery/64358240/SPECIAL-MinamiShots I'm not seeing any difference between the images downloaded using smallToFull and the ones not, can you give me a test link so I can confirm that the ripper now downloads full sized images?

imageURLs.add(imageURL);
}
} catch (NullPointerException e) {
Expand Down