Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for 8ch.net and yuki.la in ChanRipper.java #327

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added support for 8ch.net and yuki.la in ChanRipper.java #327

wants to merge 1 commit into from

Conversation

infamix
Copy link

@infamix infamix commented Dec 8, 2017

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

  • a bug fix (Fix #...)
  • a new Ripper
  • a refactoring
  • a style change/fix

Description

I've added support for 8chan (8ch.net) and yuki.la 4chan archive threads in ChanRipper,
which were missing.

Testing

Required verification:

  • I've verified that there are no regressions in mvn test (there are no new failures or errors).
  • I've verified that this change works as intended.
    • Downloads all relevant content.
    • Downloads content from multiple pages (as necessary or appropriate).
    • Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.
  • I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

  • I've added a unit test to cover my change.

@cyian-1756 cyian-1756 self-requested a review December 9, 2017 15:13
@@ -86,7 +89,8 @@ public boolean canRip(URL url) {
}
}
return url.toExternalForm().contains("/res/") // Most chans
|| url.toExternalForm().contains("/thread/"); // 4chan, archive.moe
|| url.toExternalForm().contains("/thread/") // 4chan, archive.moe
|| url.toExternalForm().contains("/"); // yuki.la, etc
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

|| url.toExternalForm().contains("/"); // yuki.la, etc is way to greedy. Try changing it to a regex that will only match yuki.la links.

@rudolphos
Copy link

rudolphos commented Dec 22, 2017

I have a request and I didn't want to make a new request thread. But would it be possible to add way to download images/videos with original image names instead of numbers?

DL from https://media.8ch.net/xxx/file_dl/xxx.jpg/xxx.jpg instead of https://media.8ch.net/xxx/src/xxx.jpg

file_dl has original file names, but /src/ serves images with number file names.

@infamix also a ripper for 4plebs.org would be great.

@cyian-1756
Copy link
Collaborator

@rudolphos

But would it be possible to add way to download images/videos with original image names instead of numbers?

Yea it could.

@metaprime metaprime changed the base branch from master to main January 5, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants