Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

Feature/control robot via interface #1319

Open
wants to merge 9 commits into
base: development
Choose a base branch
from

Conversation

emielsteerneman
Copy link
Member

@emielsteerneman emielsteerneman commented Jan 23, 2022

Comments for the reviewer

A new play called ControlSelectedRobot allows for a robot to be driven around by selecting the robot and right-clicking on the interface. I did try to keep the changes to other files to a minumum. Unfortunately, I had to put the pointer to the interface in the global scope, since there is currently no other way to reach it from a Play. It is done in the same way IOManager is made global.

The pointer should probably be replaced with an actual object like IOManager or something, but I'm not sure how to do that at the moment.

There is a high chance this might not work without first merging the Dealer PR

Pre pull request checklist:

Code Quality
  • Is the code is understandable and easy to read
  • Changes to the code comply with set clang-format rules
  • No use of manual memory control (e.g new/malloc/colloc etc)
  • Are (only) smart pointers used?
Testing
  • All tests are passing.
  • I added new / changed existing tests to reflect code changes (state why not otherwise!)
  • I tested my changes manually (Describe how, to what extent etc.)
Commit Messages
  • Commit message is saying what has been changed, why it was changed? Remember other developers might not know
    what the problem you are fixing was. Note also negative decision (e.g., why did you not do particular thing)
    TLDR: Commit message are comprehensive
  • Commit messages follows the rules of https://chris.beams.io/posts/git-commit/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants