use permissive QoS to ensure compatibilty with publishers #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been marked as stale because there has been no activity in the past 6 months. Please add a comment to keep it open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public API Changes
None
Description
Changes the topic subscription default QoS reliability to
BEST_EFFORTbecause aBEST_EFFORTsubscription is compatible with bothBEST_EFFORTandRELIABLEas opposed toRELIABLEwhich is only compatible withRELIABLEpublishers.This change addresses the issue with creating subscribers before a topic is published and ensures compatibility. See discussion at #769