Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile warnings #176

Merged
merged 6 commits into from
Dec 26, 2024
Merged

Conversation

Mat198
Copy link
Contributor

@Mat198 Mat198 commented Dec 20, 2024

Enabling compile warnings as errors to avoid future bugs.

My current job require these flags on so I thoght it would be nice to include these little changes here.

Hope it helps.

Copy link
Collaborator

@bjsowa bjsowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the effort but would you mind removing the Werror option? I'm not a fan of it as it creates a dependency on specific toolchain versions.

src/libav_streamer.cpp Outdated Show resolved Hide resolved
mth_sousa and others added 2 commits December 26, 2024 16:12
Co-authored-by: Błażej Sowa <bsowa123@gmail.com>
@Mat198
Copy link
Contributor Author

Mat198 commented Dec 26, 2024

I appreciate the effort but would you mind removing the Werror option? I'm not a fan of it as it creates a dependency on specific toolchain versions.

Flag removed

@bjsowa bjsowa merged commit 29e684c into RobotWebTools:ros2 Dec 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants