Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update thumb message layout #5872

Merged
merged 3 commits into from
Oct 25, 2024
Merged

fix: update thumb message layout #5872

merged 3 commits into from
Oct 25, 2024

Conversation

OtavioStasiak
Copy link
Contributor

@OtavioStasiak OtavioStasiak commented Sep 20, 2024

Proposed changes

Reduce the thumb image size and adjust the reply component layout to improve its distribution and optimize the space occupied by the message.

Issue(s)

https://rocketchat.atlassian.net/browse/NATIVE-622

How to test or reproduce

If you have one room with a message that have a thumb URL you can open this room, or you can mock this messages on List component:

Screenshots

IOS

Before - After

Image 1 Image 2

Android

Before - After

Screenshot_1727813558 after

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@CLAassistant
Copy link

CLAassistant commented Sep 20, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo.
Create a channel on our workspace, send those messages and add to PR description.
It's going to make review and QA easier.

app/containers/message/Components/Attachments/Reply.tsx Outdated Show resolved Hide resolved
Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Images on before and after look the same.

@OtavioStasiak OtavioStasiak force-pushed the fix-thumb-url-big branch 2 times, most recently from 687a0de to 142a86a Compare October 10, 2024 15:52
@OtavioStasiak OtavioStasiak merged commit 2668165 into develop Oct 25, 2024
4 of 9 checks passed
@OtavioStasiak OtavioStasiak deleted the fix-thumb-url-big branch October 25, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants