Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move edit action to top of message actions #5917

Merged

Conversation

OtavioStasiak
Copy link
Contributor

@OtavioStasiak OtavioStasiak commented Oct 15, 2024

Proposed changes

Move the Edit option to the top of message action sheet.

Issue(s)

https://rocketchat.atlassian.net/browse/NATIVE-672

How to test or reproduce

  • Open the app;
  • Go to room;
  • Send a message;
  • long press this message;
  • edit should be on top of action sheet;

Screenshots

Before After
Simulator Screenshot 1 Simulator Screenshot 2

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@diegolmello diegolmello changed the title Improve: move edit action to top of message actions feat: move edit action to top of message actions Oct 16, 2024
@OtavioStasiak OtavioStasiak force-pushed the improve-move-edit-action-to-top-of-message-actions branch from 75fa174 to f6322d0 Compare October 17, 2024 17:55
@OtavioStasiak OtavioStasiak merged commit 9f1788f into develop Oct 17, 2024
14 of 19 checks passed
@OtavioStasiak OtavioStasiak deleted the improve-move-edit-action-to-top-of-message-actions branch October 17, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants