Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: remove video thumbnails #5963

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

OtavioStasiak
Copy link
Contributor

@OtavioStasiak OtavioStasiak commented Nov 7, 2024

Proposed changes

"Revert PR #5893 due to performance issues and crashes on Android. We'll address these issues and reintroduce the Image Thumbnail feature once it's fully functional."

Issue(s)

https://rocketchat.atlassian.net/browse/NATIVE-705

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@OtavioStasiak OtavioStasiak marked this pull request as ready for review November 7, 2024 19:27
@diegolmello diegolmello changed the title fix: revert Thumbnail with expo-video-thumbnails regression: remove video thumbnails Nov 7, 2024
@diegolmello
Copy link
Member

@OtavioStasiak Missing some more details of why we'll have to revert so everyone is aware of next steps.

@diegolmello diegolmello merged commit cc64b3c into develop Nov 8, 2024
12 of 18 checks passed
@diegolmello diegolmello deleted the regression-revert-thumbnail-pr branch November 8, 2024 12:33
diegolmello pushed a commit that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants