Skip to content

Merge pull request #771 from RogerHowellDfE/RogerHowellDfE-patch-7 #1422

Merge pull request #771 from RogerHowellDfE/RogerHowellDfE-patch-7

Merge pull request #771 from RogerHowellDfE/RogerHowellDfE-patch-7 #1422

Triggered via push September 27, 2023 15:58
Status Failure
Total duration 10m 2s
Artifacts

codeql.yml

on: push
Matrix: Analyze C#
Matrix: Analyze Javascript
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 11 warnings
Analyze C# (csharp): Web/Edubase.Web.UI/Areas/Establishments/Views/Establishment/Partials/AdditionalAddresses.cshtml#L2
The type or namespace name 'CreateEditEstablishmentModel' does not exist in the namespace 'Edubase.Web.UI.Models' (are you missing an assembly reference?)
Analyze C# (csharp)
Process completed with exit code 1.
Analyze C# (csharp)
The following actions uses node12 which is deprecated and will be forced to run on node16: darenm/Setup-VSTest@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Analyze C# (csharp): Web/Edubase.Common/ChangeDescriptor.cs#L31
Microsoft.Performance : The 'this' parameter (or 'Me' in Visual Basic) of 'ChangeDescriptor.ToString(object)' is never used. Mark the member as static (or Shared in Visual Basic) or use 'this'/'Me' in the method body or at least one property accessor, if appropriate.
Analyze C# (csharp): Web/Edubase.Common/ChangeDescriptor.cs#L31
Microsoft.Globalization : Because the behavior of 'DateTime.ToString(string)' could vary based on the current user's locale settings, replace this call in 'ChangeDescriptor.ToString(object)' with a call to 'DateTime.ToString(string, IFormatProvider)'. If the result of 'DateTime.ToString(string, IFormatProvider)' will be displayed to the user, specify 'CultureInfo.CurrentCulture' as the 'IFormatProvider' parameter. Otherwise, if the result will be stored and accessed by software, such as when it is persisted to disk or to a database, specify 'CultureInfo.InvariantCulture'.
Analyze C# (csharp): Web/Edubase.Common/Disposer.cs#L73
Microsoft.Usage : Change 'Disposer.Dispose()' to call 'GC.SuppressFinalize(object)'. This will prevent derived types that introduce a finalizer from needing to re-implement 'IDisposable' to call it.
Analyze C# (csharp): Web/Edubase.Common/Disposer.cs#L57
Microsoft.Design : Replace method 'Disposer.Timed(Action, Action<long>)' with an overload that supplies all default arguments.
Analyze C# (csharp): Web/Edubase.Common/Disposer.cs#L64
Microsoft.Design : In externally visible method 'Disposer.Using<T>(Func<T>, Action<T>, Action<T>, Action<T>)', validate parameter 'factory' before using it.
Analyze C# (csharp): Web/Edubase.Common/Disposer.cs#L67
Microsoft.Design : In externally visible method 'Disposer.Using<T>(Func<T>, Action<T>, Action<T>, Action<T>)', validate parameter 'before' before using it.
Analyze C# (csharp): Web/Edubase.Common/Disposer.cs#L69
Microsoft.Design : In externally visible method 'Disposer.Using<T>(Func<T>, Action<T>, Action<T>, Action<T>)', validate parameter 'after' before using it.
Analyze C# (csharp): Web/Edubase.Common/Disposer.cs#L68
Microsoft.Design : In externally visible method 'Disposer.Using<T>(Func<T>, Action<T>, Action<T>, Action<T>)', validate parameter 'meat' before using it.
Analyze C# (csharp): Web/Edubase.Common/Guard.cs#L38
Microsoft.Design : Consider a design where 'Guard.Is<T>(object, Func<Exception>)' doesn't require explicit type parameter 'T' in any call to it.
Analyze C# (csharp): Web/Edubase.Common/Guard.cs#L38
Microsoft.Naming : In method 'Guard.Is<T>(object, Func<Exception>)', correct the spelling of 'fnc' in parameter name 'fnc' or remove it entirely if it represents any sort of Hungarian notation.