PHP 8.3 fixes #57
Open
PHP 8.3 fixes #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have no idea why this also pulled in my svg fix branch, I thought that was already merged in EDIT: ah I see, github's being confusing again |
fluffy-critter
force-pushed
the
php-8.3-fixes
branch
from
fcb21d9
to
9dc52d9
Compare
A lot of stuff has been deprecated or made stricter with return type annotations. Also, the SimplePie ad-hoc autoloader stopped working, so I switched it to use [Composer](https://getcomposer.org/) to manage the external dependencies. I have verified that this still works with PHP 8.1, although I cannot guarantee it on older versions.
fluffy-critter
force-pushed
the
php-8.3-fixes
branch
from
9dc52d9
to
273b29b
Compare
|
I've added a preflight check at the start of fof-install.php to ensure composer has been run, since that also caused some confusion for me when I attempted a new deployment. |
fluffy-critter
force-pushed
the
php-8.3-fixes
branch
from
ca6fccc
to
8aebc56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update everything to work with PHP 8.3
A lot of stuff has been deprecated or made stricter with return type annotations. Also, the SimplePie ad-hoc autoloader stopped working, so I switched it to use Composer to manage the external dependencies (SimplePie and urljoin). This also means that anyone installing or upgrading will need to run
composer install(this has been documented in the README).I have verified that this still works with PHP 8.1, although I cannot guarantee it on older versions.