call petpet-rs CLI instead of generate in kotlin #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mokurin000
changed the title
mokurin000
changed the title
Closed
Rosemoe
reviewed
Aug 11, 2021
src/main/kotlin/io/github/rosemoe/miraiPlugin/modules/PetPet.kt
Outdated
Show resolved
Hide resolved
Rosemoe
reviewed
Aug 11, 2021
src/main/kotlin/io/github/rosemoe/miraiPlugin/modules/PetPet.kt
Outdated
Show resolved
Hide resolved
Rosemoe
reviewed
Aug 11, 2021
src/main/kotlin/io/github/rosemoe/miraiPlugin/modules/PetPet.kt
Outdated
Show resolved
Hide resolved
Rosemoe
reviewed
Aug 11, 2021
src/main/kotlin/io/github/rosemoe/miraiPlugin/modules/PetPet.kt
Outdated
Show resolved
Hide resolved
Rosemoe
reviewed
Aug 11, 2021
src/main/kotlin/io/github/rosemoe/miraiPlugin/modules/PetPet.kt
Outdated
Show resolved
Hide resolved
|
啊这 忘了merge吗（ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
通过性能测试，我发现确实Shell调用的开销比起编码非常小，
而且
JNI没有糊好二进制更方便分发，所以使用CLI调用。需要在mirai运行目录下放好 petpet
fix #20,fix #18
通过我本地的测试了