Skip to content

Commit

Permalink
added aria hidden
Browse files Browse the repository at this point in the history
  • Loading branch information
@elliotrpmorris-zz
elliotrpmorris-zz committed May 9, 2019
1 parent 7e0a4b0 commit 69adff8
Show file tree
Hide file tree
Showing 17 changed files with 80 additions and 77 deletions.
4 changes: 2 additions & 2 deletions src/partials/buttons-and-links.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ <h4 class="section__subtitle">Alt</h4>
</div>
<div class="col-xsmall-12 col-medium-6">
<h6 class="section__modifier">Medium</h6>
<button class="btn btn--alt btn--alt--m">Add to favourites <i class="btn__icon fas fa-star"></i></button>
<button class="btn btn--alt btn--alt--m">Add to favourites <i aria-hidden="true" class="btn__icon fas fa-star"></i></button>
<!--Code-->
<div class="container">
<details>
Expand All @@ -84,7 +84,7 @@ <h6 class="section__modifier">Medium</h6>
</div>
<div class="col-xsmall-12 col-medium-6">
<h6 class="section__modifier">Small</h6>
<button class="btn btn--alt btn--alt--s">Give Feedback <i class="btn__icon fas fa-comment"></i></button>
<button class="btn btn--alt btn--alt--s">Give Feedback <i aria-hidden="true" class="btn__icon fas fa-comment"></i></button>
<!--Code-->
<div class="container">
<details>
Expand Down
34 changes: 17 additions & 17 deletions src/partials/card.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ <h5 class="section__subtitle">Whos it for</h5>
<div class="col-small-12 col-medium-4">
<article class="card--whos-it-for row -large-no-gutters">
<div class="card--whos-it-for__title col-xsmall-4">
<i class="card--whos-it-for__icon fas fa-birthday-cake"></i>
<i aria-hidden="true" class="card--whos-it-for__icon fas fa-birthday-cake"></i>
<p class="body--s">Age group</p>
</div>
<p class="col-xsmall-8">Avoiding a house crisis</p>
Expand Down Expand Up @@ -77,7 +77,7 @@ <h5 class="section__subtitle">What people say</h5>
</div>
<div class="col-xsmall-12 col-small-8 col-large-6">
<article class="card--what-people-say">
<i class="card--what-people-say__icon fas fa-comment"></i>
<i aria-hidden="true" class="card--what-people-say__icon fas fa-comment"></i>
<p class="body--alt">
“ I’ve brought my child here for a couple of weeks and it’s a great place
to have fun and meet new people with simliar situations to us. ”
Expand Down Expand Up @@ -109,18 +109,18 @@ <h4 class="card--access-it__title">New Malden Library</h4>
</div>
<div class="card--access-it__maps row -xsmall-no-gutters">
<a class="card--access-it__maps-link" href="/">
View on Google Maps <i class="fas fa-map"></i>
View on Google Maps <i aria-hidden="true" class="fas fa-map"></i>
</a>
<a href="/">
Get directions on Google Maps <i class="fas fa-map-signs"></i>
Get directions on Google Maps <i aria-hidden="true" class="fas fa-map-signs"></i>
</a>
</div>
</div>
<div
class="col-xsmall-12 col-small-5 col-small-offset-1 card--access-it__hours -xsmall-no-gutters"
>
<p class="card--access-it__title">
<i class="far fa-clock"></i> Opening hours
<i aria-hidden="true" class="far fa-clock"></i> Opening hours
</p>
<p class="body--s">Monday to friday <strong>9am to 9:30pm</strong></p>
<details class="accordion--time">
Expand All @@ -135,7 +135,7 @@ <h5 class="section__subtitle">Good to know</h5>
<div class="col-xsmall-12 col-small-6">
<article class="card--good-to-know">
<div class="card--good-to-know__item">
<i class="card--good-to-know__icon fas fa-map-signs"></i>
<i aria-hidden="true" class="card--good-to-know__icon fas fa-map-signs"></i>
<div>
<h4 class="card--good-to-know__title">Getting here</h4>
<p class="body--s card--good-to-know__text">
Expand All @@ -145,7 +145,7 @@ <h4 class="card--good-to-know__title">Getting here</h4>
</div>
</div>
<div class="card--good-to-know__item">
<i class="card--good-to-know__icon fas fa-map-signs"></i>
<i aria-hidden="true" class="card--good-to-know__icon fas fa-map-signs"></i>
<div>
<h4 class="card--good-to-know__title">Getting here</h4>
<p class="body--s card--good-to-know__text">
Expand All @@ -155,7 +155,7 @@ <h4 class="card--good-to-know__title">Getting here</h4>
</div>
</div>
<div class="card--good-to-know__item">
<i class="card--good-to-know__icon fas fa-map-signs"></i>
<i aria-hidden="true" class="card--good-to-know__icon fas fa-map-signs"></i>
<div>
<h4 class="card--good-to-know__title">Getting here</h4>
<p class="body--s card--good-to-know__text">
Expand All @@ -173,38 +173,38 @@ <h5 class="section__subtitle">How can i contact this group</h5>
<article class="card--contact-group">
<div class="card--contact-group__item">
<h4 class="card--contact-group__title">
<i class="fas fa-globe"></i> Website
<i aria-hidden="true" class="fas fa-globe"></i> Website
</h4>
<a href="kingston.gov.uk/kingstonadulteducation…"
>kingston.gov.uk/kingstonadulteducation…</a
>
</div>
<div class="card--contact-group__item">
<h4 class="card--contact-group__title">
<i class="fas fa-phone"></i> Telephone
<i aria-hidden="true" class="fas fa-phone"></i> Telephone
</h4>
<a href="tel:02085476700">020 8547 6700</a>
</div>
<div class="card--contact-group__item">
<h4 class="card--contact-group__title">
<i class="fas fa-envelope"></i> Email
<i aria-hidden="true" class="fas fa-envelope"></i> Email
</h4>
<a href="mailto:adult.eductation@kingston.gov.uk"
>adult.eductation@kingston.gov.uk</a
>
</div>
<div class="card--contact-group__social row -xsmall-center">
<a class="card--contact-group__social-link" href="/"
><i class="fab fa-facebook-f"></i
><i aria-hidden="true" class="fab fa-facebook-f"></i
></a>
<a class="card--contact-group__social-link" href="/"
><i class="fab fa-twitter"></i
><i aria-hidden="true" class="fab fa-twitter"></i
></a>
<a class="card--contact-group__social-link" href="/"
><i class="fab fa-instagram"></i
><i aria-hidden="true" class="fab fa-instagram"></i
></a>
<a class="card--contact-group__social-link" href="/"
><i class="fab fa-youtube"></i
><i aria-hidden="true" class="fab fa-youtube"></i
></a>
</div>
</article>
Expand All @@ -224,7 +224,7 @@ <h5 class="section__subtitle">Who runs this service</h5>
<div class="card--runs-service__content">
<h4 class="card--runs-service__title">King adult education</h4>
<a class="card--runs-service__link" href="/"
>View all services from org <i class="fas fa-arrow-right"></i
>View all services from org <i aria-hidden="true" class="fas fa-arrow-right"></i
></a>
</div>
</article>
Expand All @@ -241,7 +241,7 @@ <h3 class="card--related-services__title">Arts & craft</h3>
</p>
<footer class="row -xsmall-no-gutters -xsmall-space-between">
<button class="btn btn--s">
View more <i class="btn__icon fas fa-chevron-right"></i>
View more <i aria-hidden="true" class="btn__icon fas fa-chevron-right"></i>
</button>
<img src="https://via.placeholder.com/55" alt="Logo" />
</footer>
Expand Down
6 changes: 3 additions & 3 deletions src/partials/footer.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -35,23 +35,23 @@ <h4>
target="_blank"
role="menuitem"
aria-label="Facebook page link"
><i class="fab fa-facebook-f"></i
><i aria-hidden="true" class="fab fa-facebook-f"></i
></a>
<a
class="social-bar__item"
href="https://twitter.com/ConnectedKings"
target="_blank"
role="menuitem"
aria-label="Twitter page link"
><i class="fab fa-twitter"></i
><i aria-hidden="true" class="fab fa-twitter"></i
></a>
<a
class="social-bar__item"
href="https://instagram.com/ConnectedKings"
target="_blank"
role="menuitem"
aria-label="Instagram page link"
><i class="fab fa-instagram"></i
><i aria-hidden="true" class="fab fa-instagram"></i
></a>
</nav>
</div>
Expand Down
6 changes: 3 additions & 3 deletions src/partials/good-to-know.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<div class="accordion__content">
<article class="card--good-to-know">
<div class="card--good-to-know__item">
<i class="card--good-to-know__icon fas fa-map-signs"></i>
<i aria-hidden="true" class="card--good-to-know__icon fas fa-map-signs"></i>
<div>
<h4 class="card--good-to-know__title">Getting here</h4>
<p class="body--s card--good-to-know__text">
Expand All @@ -13,7 +13,7 @@ <h4 class="card--good-to-know__title">Getting here</h4>
</div>
</div>
<div class="card--good-to-know__item">
<i class="card--good-to-know__icon fas fa-car"></i>
<i aria-hidden="true" class="card--good-to-know__icon fas fa-car"></i>
<div>
<h4 class="card--good-to-know__title">Getting here</h4>
<p class="body--s card--good-to-know__text">
Expand All @@ -23,7 +23,7 @@ <h4 class="card--good-to-know__title">Getting here</h4>
</div>
</div>
<div class="card--good-to-know__item">
<i class="card--good-to-know__icon fas fa-pen-alt"></i>
<i aria-hidden="true" class="card--good-to-know__icon fas fa-pen-alt"></i>
<div>
<h4 class="card--good-to-know__title">Getting here</h4>
<p class="body--s card--good-to-know__text">
Expand Down
14 changes: 7 additions & 7 deletions src/partials/header.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@
<!--Options nav-->
<nav class="nav--options nav--desktop col-xsmall-6 col-small-6 -xsmall-end">
<a class="nav--options__item btn btn--header" href="#"
>Translate <i class="btn__icon fas fa-language"></i
>Translate <i aria-hidden="true" class="btn__icon fas fa-language"></i
></a>
<a class="nav--options__item btn btn--header" href="#"
>Give feedback <i class="btn__icon fas fa-comment"></i
>Give feedback <i aria-hidden="true" class="btn__icon fas fa-comment"></i
></a>
<a class="nav--options__item btn btn--header" href="#"
>View favourites <i class="btn__icon fas fa-star"></i
>View favourites <i aria-hidden="true" class="btn__icon fas fa-star"></i
></a>
</nav>
<!--Pages nav-->
Expand All @@ -29,7 +29,7 @@
role="button"
>
<label class="nav--hamburger__label" for="nav--hamburger"></label>
<i class="nav--hamburger__icon bars fa fa-bars" title="Menu Trigger"></i>
<i aria-hidden="true" class="nav--hamburger__icon bars fa fa-bars" title="Menu Trigger"></i>
</button>
<nav
class="nav--menu nav--desktop col-xsmall-12 col-medium-offset-6 -medium-end"
Expand Down Expand Up @@ -59,11 +59,11 @@
</nav>
<nav class="nav--options col-xsmall-12 -xsmall-no-gutters">
<a class="nav--options__item btn--header" href="/"
>Translate <i class="btn__icon fas fa-language"></i></a
>Translate <i aria-hidden="true" class="btn__icon fas fa-language"></i></a
><a class="nav--options__item btn--header" href="/"
>Give feedback <i class="btn__icon fas fa-comment"></i></a
>Give feedback <i aria-hidden="true" class="btn__icon fas fa-comment"></i></a
><a class="nav--options__item btn--header" href="/"
>View favourites <i class="btn__icon fas fa-star"></i
>View favourites <i aria-hidden="true" class="btn__icon fas fa-star"></i
></a>
</nav>
</div>
Expand Down
18 changes: 9 additions & 9 deletions src/partials/how-can-i-contact-this-group.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,48 +3,48 @@
<div class="accordion__content">
<article class="card--make-connection">
<button class="btn btn--l">
Make connection <i class="btn__icon fas fa-arrow-right"></i>
Make connection <i aria-hidden="true" class="btn__icon fas fa-arrow-right"></i>
</button>
<p class="card--make-connection__text">
<i class="card--make-connection__icon fas fa-info-circle"></i> It can take
<i aria-hidden="true" class="card--make-connection__icon fas fa-info-circle"></i> It can take
<strong>up to 2 weeks</strong> to recieve a reply
</p>
</article>
<article class="card--contact-group">
<div class="card--contact-group__item">
<h4 class="card--contact-group__title">
<i class="card--contact-group__icon fas fa-globe"></i> Website
<i aria-hidden="true" class="card--contact-group__icon fas fa-globe"></i> Website
</h4>
<a href="kingston.gov.uk/kingstonadulteducation…"
>kingston.gov.uk/kingstonadulteducation…</a
>
</div>
<div class="card--contact-group__item">
<h4 class="card--contact-group__title">
<i class="card--contact-group__icon fas fa-phone"></i> Telephone
<i aria-hidden="true" class="card--contact-group__icon fas fa-phone"></i> Telephone
</h4>
<a href="tel:02085476700">020 8547 6700</a>
</div>
<div class="card--contact-group__item">
<h4 class="card--contact-group__title">
<i class="card--contact-group__icon fas fa-envelope"></i> Email
<i aria-hidden="true" class="card--contact-group__icon fas fa-envelope"></i> Email
</h4>
<a href="mailto:adult.eductation@kingston.gov.uk"
>adult.eductation@kingston.gov.uk</a
>
</div>
<div class="card--contact-group__social row -xsmall-center">
<a class="card--contact-group__social-link" href="/"
><i class="fab fa-facebook-f"></i
><i aria-hidden="true" class="fab fa-facebook-f"></i
></a>
<a class="card--contact-group__social-link" href="/"
><i class="fab fa-twitter"></i
><i aria-hidden="true" class="fab fa-twitter"></i
></a>
<a class="card--contact-group__social-link" href="/"
><i class="fab fa-instagram"></i
><i aria-hidden="true" class="fab fa-instagram"></i
></a>
<a class="card--contact-group__social-link" href="/"
><i class="fab fa-youtube"></i
><i aria-hidden="true" class="fab fa-youtube"></i
></a>
</div>
</article>
Expand Down
4 changes: 2 additions & 2 deletions src/partials/image-viewer.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@
alt="img"
/>
<div class="image-viewer__overlay">
<i class="image-viewer__overlay-icon fas fa-images"></i>
<i aria-hidden="true" class="image-viewer__overlay-icon fas fa-images"></i>
</div>
</div>
</div>
<a class="image-viewer__text"
><i class="image-viewer__icon fas fa-camera"></i> View images (4)</a
><i aria-hidden="true" class="image-viewer__icon fas fa-camera"></i> View images (4)</a
>
</div>
2 changes: 1 addition & 1 deletion src/partials/page/media.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ <h5 class="section__subtitle">Image</h5>
</div>
</div>
<a class="image-viewer__text"
><i class="image-viewer__icon fas fa-camera"></i> View images (4)</a
><i aria-hidden="true" class="image-viewer__icon fas fa-camera"></i> View images (4)</a
>
</div>
</div>
Expand Down
6 changes: 3 additions & 3 deletions src/partials/related-services.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ <h3 class="card--related-services__title">Arts & craft</h3>
</p>
<footer class="card--related-services__footer row -xsmall-no-gutters -xsmall-space-between">
<button class="btn btn--s">
View more <i class="btn__icon fas fa-chevron-right"></i>
View more <i aria-hidden="true" class="btn__icon fas fa-chevron-right"></i>
</button>
<img src="https://via.placeholder.com/55" alt="Logo" />
</footer>
Expand All @@ -31,7 +31,7 @@ <h3 class="card--related-services__title">
</p>
<footer class="card--related-services__footer row -xsmall-no-gutters -xsmall-space-between">
<button class="btn btn--s">
View more <i class="btn__icon fas fa-chevron-right"></i>
View more <i aria-hidden="true" class="btn__icon fas fa-chevron-right"></i>
</button>
<img src="https://via.placeholder.com/55" alt="Logo" />
</footer>
Expand All @@ -46,7 +46,7 @@ <h3 class="card--related-services__title">Kingston Arts Council</h3>
</p>
<footer class="card--related-services__footer row -xsmall-no-gutters -xsmall-space-between">
<button class="btn btn--s">
View more <i class="btn__icon fas fa-chevron-right"></i>
View more <i aria-hidden="true" class="btn__icon fas fa-chevron-right"></i>
</button>
<img src="https://via.placeholder.com/55" alt="Logo" />
</footer>
Expand Down
Loading

0 comments on commit 69adff8

Please sign in to comment.